Skip to content

Add archiving metrics code with timer #23902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
caddoo merged 35 commits into from
Jan 19, 2026
Merged

Add archiving metrics code with timer #23902

caddoo merged 35 commits into from
Jan 19, 2026
+1,356 −21

Conversation

@caddoo
Copy link
Contributor

@caddoo caddoo commented Dec 16, 2025 •
edited
Loading

Description

Adds a simple timing class for archiving context, recording results in this format:

archiving_metrics
├─ metadataid             BIGINT UNSIGNED PK AUTO_INCREMENT
├─ idarchive              BIGINT UNSIGNED NULL (idx: idx_archiving_metrics_idarchive)
├─ idsite                 INTEGER UNSIGNED NOT NULL
├─ segment                VARCHAR(255) NULL
├─ date1                  DATE NOT NULL
├─ date2                  DATE NOT NULL
├─ period                 VARCHAR(10) NOT NULL (idx: idx_archiving_metrics_site_date_period on idsite, date1, period)
├─ ts_started             DATETIME NOT NULL
├─ ts_finished            DATETIME NOT NULL
├─ total_time             BIGINT UNSIGNED NOT NULL
└─ total_time_exclusive   BIGINT UNSIGNED NOT NULL

Follow up will be integrating with the archiving process
and then a cleanup scheduled task to remove old data.

Checklist

  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules

Review

@caddoo caddoo force-pushed the dev-19750-timing-metrics branch 6 times, most recently from d089e53 to 9e837dc Compare December 17, 2025 21:01
@caddoo caddoo marked this pull request as ready for review December 17, 2025 22:20
@caddoo caddoo requested a review from mneudert December 17, 2025 22:20
@caddoo caddoo mentioned this pull request Dec 18, 2025
Merged
10 tasks
@caddoo caddoo force-pushed the dev-19750-timing-metrics branch 2 times, most recently from 887b7ba to f08ed6e Compare December 19, 2025 02:21
@caddoo caddoo added this to the 5.7.0 milestone Dec 19, 2025
mneudert
mneudert reviewed Dec 19, 2025
View reviewed changes
@caddoo caddoo requested a review from mneudert December 23, 2025 23:47
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jan 7, 2026
@caddoo
Copy link
Contributor Author

caddoo commented Jan 13, 2026

@mneudert I've addressed all the feedback now.

I've also added support for measuring 'report' archive timing.

mneudert
mneudert reviewed Jan 13, 2026
View reviewed changes
mneudert
mneudert reviewed Jan 14, 2026
View reviewed changes
@caddoo caddoo force-pushed the dev-19750-timing-metrics branch from bd748f3 to ea1993b Compare January 16, 2026 00:39
@caddoo caddoo modified the milestones: 5.7.0, 6.0.0 Jan 16, 2026
@caddoo caddoo force-pushed the dev-19750-timing-metrics branch 2 times, most recently from 0bd0623 to f8cb810 Compare January 16, 2026 01:01
@caddoo caddoo modified the milestone: 5.7.0 Jan 16, 2026
@caddoo caddoo requested a review from mneudert January 16, 2026 05:25
caddoo added 21 commits January 16, 2026 17:06
@caddoo @mneudert
Use mocks for Timer tests
e3b2716
@caddoo @mneudert
Move ArchivingMetrics description to lang file
8cae024
@caddoo @mneudert
Tighten ArchivingMetrics integration test
6759035
@caddoo @mneudert
Add strict types and license headers
a95a42f
@caddoo @mneudert
Move context field extraction into writer
713e56c
@caddoo @mneudert
Update screenshots
c742bbf
@caddoo @mneudert
Store done flag as archive name
c448132
@caddoo @mneudert
Add support for report timings
8dde0bb
@caddoo @mneudert
Remove null check
099b80c
@caddoo @mneudert
Update index names
f87db72
@caddoo @mneudert
Add check to make sure idArchives array is always 1
c5a6652
@caddoo @mneudert
Update index name
b0d2ca0
@caddoo @mneudert
Switch to date function
c27b944
@caddoo @mneudert
Remove date now() function
b9e061f
@caddoo @mneudert
Add 'type' to $runs
8e0c2ed
@caddoo @mneudert
Add clean up task for archive metrics (#23907)
9f65f9f 
* Add clean up task for archive metrics

* Add deleted-site purge for archiving metrics

* Remove not needed setup/teardown

* Add strict types

* Update UI screenshot
@caddoo @mneudert
Integrate archiveReports with ArchiveMetrics timer (#23906)
e4cdeb3 
* Integrate archiveReports with ArchiveMetrics timer

* Create event and hook timer into it

* Add better typing

* Make sure plugin is loaded for integration test

* Skip metrics for single-report archiving

* Add test-only timer reset helper

* Simplify archive loader test GET handling

* Add nullable type for instance

* cs fix

* Add strict types

* Allow reports to have metrics recorded
@caddoo @mneudert
Update test to remove mocked 'now'
0ceb6ab
@caddoo @mneudert
Remove report from archiving metrics context
0ccc6a9
@caddoo @mneudert
Add report to context only
d26df02
@caddoo @mneudert
Clean up test
a34bf5e
@mneudert mneudert force-pushed the dev-19750-timing-metrics branch from 06180da to a34bf5e Compare January 16, 2026 16:06
mneudert
mneudert approved these changes Jan 16, 2026
View reviewed changes
Copy link
Member

@mneudert mneudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added another timer test for a full cascade of year down to day (with two different weeks), just for a bit more details on how the exclusive time is calculated in those rare cases.

@caddoo caddoo modified the milestone: 5.7.0 Jan 19, 2026
@caddoo caddoo merged commit ef41360 into 5.x-dev Jan 19, 2026
29 of 31 checks passed
@caddoo caddoo deleted the dev-19750-timing-metrics branch January 19, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mneudert mneudert mneudert approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

5.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@caddoo @mneudert